WESTMIDLANDS| ITP-MAY 2025| ROJA ALAGURAJAN| Module Structuring and Testing Data|sprint 2 #612
Conversation
alagurajan-roja
changed the title
alagurajan-roja
changed the title
| const bmi = weightKg / square; | ||
| // return the BMI to 1 decimal | ||
| return bmi.toFixed(1); |
There was a problem hiding this comment.
What type of value do you expect the function to return? A number or a string?
Does your function return the type of value you expect it to return?
There was a problem hiding this comment.
Hi @cjyuan,
I expect the function to return a number, since BMI is a numeric value used for further analysis, such as comparing it to health category thresholds (e.g., underweight, normal, overweight).
However, in the current version of the function, it returns a string, because the .toFixed(1) method formats the number to 1 decimal place but returns it as a string.
| square=(heightM*heightM); |
There was a problem hiding this comment.
Where is square being declared?
There was a problem hiding this comment.
Hi @cjyuan
In the corrected version of the code, square is declared inside the calculateBMI function using the const keyword:
const square = heightM * heightM;
| function formatAs12HourClock(time) { | ||
| const [hourStr, minuteStr] = time.split(":"); | ||
| let hours = Number(hourStr); | ||
| const minutes = minuteStr; |
There was a problem hiding this comment.
Why not just use minuteStr instead of introducing another variable?
There was a problem hiding this comment.
Hi @cjyuan ,
I have updated and corrected the code based on your feedback. Please take a look and let me know if you have any further suggestions or improvements.
cjyuan
added
Reviewed
alagurajan-roja
added
Needs Review
|
Changes look good! Well done. |
cjyuan
added
Complete
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Completed all mandatory coursework, including:
1.Exercises
2.Error handling tasks
3.Code interpretation and explanation
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.